Re: [PATCH] [SCSI] gdth: Allocate sense_buffer to prevent NULL pointer dereference

From: Matthew Dharm
Date: Tue Mar 11 2008 - 13:42:23 EST


On Tue, Mar 11, 2008 at 06:16:16PM +0200, Boaz Harrosh wrote:
> I would like to fix this better by calling scsi_get/put_command but there is
> something fundamental that bothers me with isd200 driver. I can see that
> an isd200_info struct is allocated and put on a struct us_data->extra. But
> as I understand the code, the struct us_data is associated with a scsi_host
> not a scsi_device. Are we guarantied that we have only one scsi_device
> per host at all times?

Yes. We allocate a scsi_host for each USB device that we see. The only
time you can have more than one scsi_device is in the case of multi-target
devices, of which the ISD-200 is NOT one.

Matt

--
Matthew Dharm Home: mdharm-usb@xxxxxxxxxxxxxxxxxx
Maintainer, Linux USB Mass Storage Driver

Hey, has anyone seen the Microsoft sales guy? It's his feeding time...
-- Mike
User Friendly, 4/17/1998

Attachment: pgp00000.pgp
Description: PGP signature