Re: [WATCHDOG] v2.5.25-rc patches

[Oliver Schuster]

Hi,

WARNING

this patch can cause serious problems in the case, that someone use it 
with an it8712 rev. 8 and above.

Wim Van Sebroeck wrote:
> Hi Linus,
>
> Please pull from 'master' branch of
> 	git://git.kernel.org/pub/scm/linux/kernel/git/wim/linux-2.6-watchdog.git
> or if master.kernel.org hasn't synced up yet:
> 	master.kernel.org:/pub/scm/linux/kernel/git/wim/linux-2.6-watchdog.git
>
> This will update the following files: 
>  ....

Your patch changes it8712f_wdt.c in function t8712f_wdt_update_margin():

> -	superio_outb((margin > 255) ? (margin / 60) : margin, WDT_TIMEOUT);
> +	if (revision >= 0x08)
> +		superio_outw(units, WDT_TIMEOUT);
> +	else
> +		superio_outb(units, WDT_TIMEOUT);

but here you can't use superio_outw, because the bytes are swapped 
--historical reason.

I suggest to substitute
	superio_outw(units, WDT_TIMEOUT);
with
	superio_outb(units >> 8, WDT_TIMEOUT + 1);
	superio_outb(units, WDT_TIMEOUT);

or to change the patch with (only the referenced position above)

+	if (revision >= 0x08)
+		superio_outb(units >> 8, WDT_TIMEOUT + 1);
+
+	superio_outb(units, WDT_TIMEOUT);

I'm sorry, that I resend this message.
Now I'm able to respond correctly to existing thread.

Regards,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/