Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine

[Kumar Gala]

> > > > Also this driver from git-md-accel is pretty sick:
> > > >
> > > >
> > > > drivers/dma/fsldma.c:439: warning: comparison of distinct pointer  
> > > > types lacks a cast
> > > > drivers/dma/fsldma.c: In function `fsl_chan_xfer_ld_queue':
> > > > drivers/dma/fsldma.c:584: warning: long long unsigned int format,  
> > > > dma_addr_t arg (arg 4)
> > > > drivers/dma/fsldma.c: In function `fsl_dma_chan_do_interrupt':
> > > > drivers/dma/fsldma.c:661: warning: unsigned int format, different  
> > > > type arg (arg 5)
> > > > drivers/dma/fsldma.c:677: warning: long long unsigned int format,  
> > > > dma_addr_t arg (arg 4)
> > > > drivers/dma/fsldma.c:677: warning: long long unsigned int format,  
> > > > dma_addr_t arg (arg 5)
> > > > drivers/dma/fsldma.c:694: warning: unsigned int format, different  
> > > > type arg (arg 4)
> > > > drivers/dma/fsldma.c: In function `fsl_dma_self_test':
> > > > drivers/dma/fsldma.c:833: warning: int format, different type arg  
> > > > (arg 5)
> > > > drivers/dma/fsldma.c: In function `of_fsl_dma_probe':
> > > > drivers/dma/fsldma.c:1003: warning: unsigned int format,  
> > > > different type arg (arg 5)
> > > > drivers/dma/fsldma.c: At top level:
> > > > drivers/dma/fsldma.c:723: warning: 'fsl_dma_callback_test'  
> > > > defined but not used
> > >
> > > Yeah, Zhang Wei posted a patch for that on lkml yesterday.
> >
> > OK.
>
> My fault for not pushing out this cleanup to the old url while the
> git-md-accel changeover was pending.

Any reason not to push Zhang's fixes for 2.6.25?

I also have a patch I want to push for 2.6.25 to deal with the powerpc  
device tree.  I was going to handle this via the powerpc tree's since  
that seems to be the model we have used for netdev and other drivers  
that play with arch/powerpc.  I hope that's not an issue (I'll CC you  
on the patch).

- k
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/