Re: [PATCH 3/3] perfmon x86 infra(take 2): add AMD Northbridge PCI Id

[stephane eranian]

Greg,


On Tue, Mar 11, 2008 at 10:12 AM, Greg KH <gregkh@xxxxxxx> wrote:
> On Tue, Mar 11, 2008 at 09:50:36AM -0700, stephane eranian wrote:
>  > Greg,
>  >
>  > Ingo suggested I send ou the following patch which adds a PCI ID
>  > for AMD Barcelona Northbridge. This is used by the perfmon initialization
>  > code on this platform.
>  >
>  > Please apply to your tree.
>
>  We are trying to not add pci ids that are only used in one place within
>  the kernel.  Why can't the perfomon init code just add this value to
>  their code?
>
I thought you would want a central place where all PCI ids are defined.
But if you prefer not, then so be it. I'll put it into the perfmon code.

>  Or make this part of the perfmon patch itself, if you really must have
>  it.  No need to add it to the kernel if there are no in-tree users,
>  right?
>
I am starting to push perfmon patches upstream. So you should expect
patches which  *currently* have no in-tree users. You have to start from
somewhere, right?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/