Re: [PATCH] Mark early_printk as asmlinkage

[H. Peter Anvin]

Jiri Slaby wrote:
> On 03/12/2008 03:04 PM, H. Peter Anvin wrote:
> > Jiri Slaby wrote:
> > > It's not explicitly marked as asmlinkage, but invoked from x86_32
> > > startup code with parameters on stack.
> > >
> > > No other architectures define early_printk and none of them are affected
> > > by this change, since defines asmlinkage as empty token.
> >
> > NAK.
> >
> > The regparm ABI for x86-32 uses parameters on the stack when the 
> > function is varadic (as it is here), so this is unnecessary.
>
> Makes sense. Why is printk marked as asmlinkage?

Hm.  Don't know if it's historical, stylistic (anything called from 
assembly should have "asmlinkage"), or just based on a misunderstanding 
of the regparm ABI.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/