Re: [RFC] correct flags to f_mode conversion in __dentry_open

From: Andreas Schwab
Date: Wed Mar 12 2008 - 14:47:43 EST


Eric Paris <eparis@xxxxxxxxxx> writes:

> Notice that 3 == (O_RDWR | O_WRONLY)

Note that O_RDWR and O_WRONLY are not simple flags, but two possible
values of a 2-bit field (O_ACCMODE). Thus it does not makes sense to
add them together.

Andreas.

--
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/