Re: pcibios_scanned needs to be set in ACPI? (was Re: 2.6.25-rc5:Reported regressions from 2.6.24)

[Linus Torvalds]

On Wed, 12 Mar 2008, Greg KH wrote:
> 
> Actually, here's a simple patch from -next that should test this logic
> for you.  Can you let me know if this solves the start up WARNING dump
> for you?

This patch looks bogus.

Why do you introduce a "dev->is_added" field that apparently has to match 
the old "list_empty(&dev->global_list)" 1:1 anyway?

In other words: when is it *ever* permissible for "is_added" to have a 
different value from the "list_empty(..)" logic? And if they must always 
match (and it looks like they have to, since you set and clear the flag 
exactly when you add/remove it from the list), then what exactly is this 
supposed to fix?

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/