Re: [patch 3/6] Guest page hinting: mlocked pages.

From: Martin Schwidefsky
Date: Thu Mar 13 2008 - 05:13:36 EST


On Thu, 2008-03-13 at 10:27 +1100, Rusty Russell wrote:
> On Thursday 13 March 2008 00:21:35 Martin Schwidefsky wrote:
> > --- linux-2.6.orig/include/linux/fs.h
> > +++ linux-2.6/include/linux/fs.h
> > @@ -513,6 +513,9 @@ struct address_space {
> > spinlock_t private_lock; /* for use by the address_space */
> > struct list_head private_list; /* ditto */
> > struct address_space *assoc_mapping; /* ditto */
> > +#ifdef CONFIG_PAGE_STATES
> > + unsigned int mlocked; /* set if VM_LOCKED vmas present */
> > +#endif
> > } __attribute__((aligned(sizeof(long))));
>
> Minor nit: I think this would be better under private_lock where it wouldn't
> consume any extra space on 64-bit.

Yes, makes sense. I moved the #ifdef.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/