Re: [PATCH] logical-bitwise & confusion in se401_init() (was:logical-bitwise & confusion in se401_init()?)

From: Rik van Riel
Date: Thu Mar 13 2008 - 17:30:33 EST


On Thu, 13 Mar 2008 16:51:29 +0100
Roel Kluin <12o3l@xxxxxxxxxx> wrote:

> - if (!cp[2] && SE401_FORMAT_BAYER) {
> + if (!cp[2] & SE401_FORMAT_BAYER) {
> err("Bayer format not supported!");
> return 1;
> }

Would it be better to put in some additional parenthesis?

if (!(cp[2] & SE401_FORMAT_BAYER)) {

--
All Rights Reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/