Re: [PATCH] at73c213: Fix DMA size at the end of DMA buffer

[Haavard Skinnemoen]

On Mon, 10 Mar 2008 23:43:06 +0900 (JST)
Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote:

> +		size = runtime->period_size * runtime->channels;
> +		if (next_period == runtime->periods - 1)
> +			size += (runtime->buffer_size % runtime->period_size)
> +				* runtime->channels;

Ow. That looks expensive. Isn't there any way we can force the client
to select sane values of buffer_size and period_size?

It seems like a reasonable demand that buffer_size is a multiple of
period_size, doesn't it?

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/