Re: [PATCH 1/8] cleanup ntp.c

[Roman Zippel]

Hi,

On Fri, 14 Mar 2008, john stultz wrote:

> Ah crud. Ingo sent very similar changes to me a few weeks ago, and I've
> been too pinched for time to test and send them out. 
> 
> I'll spend some time today to layer his fixes as well as my own cleanups
> on top. 

What fixes?

> > +static void ntp_update_offset(long offset)
> > +{
> > +	long mtemp;
> 
> Could we change this to a more descriptive name?
> 
> Maybe last_update_interval?

It's a local variable, so IMO temp works just fine, it's not that 
difficult to figure out how it's used (e.g. it's like using loop_index 
instead of i).

bye, Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/