Re: [PATCH] Arch: x86_32, fix fault_msg nul termination

From: Ingo Molnar
Date: Fri Mar 21 2008 - 07:51:25 EST



* Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> The fault_msg text is not explictly nul terminated now in startup
> assembly. Do so by converting .ascii to .asciz.

thanks Jiri, applied.

> fault_msg:
> - .ascii \
> + .asciz \
> /* fault info: */ "BUG: Int %d: CR2 %p\n" \
> /* pusha regs: */ " EDI %p ESI %p EBP %p ESP %p\n" \
> " EBX %p EDX %p ECX %p EAX %p\n" \

i guess in practice we were saved by a NIL following this string, but
there's no guarantee indeed.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/