Re: [11/14] vcompound: Fallbacks for order 1 stack allocations onIA64 and x86

[Ingo Molnar]

* Christoph Lameter <clameter@xxxxxxx> wrote:

> On Fri, 21 Mar 2008, Ingo Molnar wrote:
> 
> > another thing is that this patchset includes KERNEL_STACK_SIZE_ORDER 
> > which has been NACK-ed before on x86 by several people and i'm 
> > nacking this "configurable stack size" aspect of it again.
> 
> Huh? Nothing of that nature is in this patchset.

your patch indeed does not introduce it here, but 
KERNEL_STACK_SIZE_ORDER shows up in the x86 portion of your patch and 
you refer to multi-order stack allocations in your 0/14 mail :-)

> -#define alloc_task_struct()	((struct task_struct *)__get_free_pages(GFP_KERNEL | __GFP_COMP, KERNEL_STACK_SIZE_ORDER))
> -#define free_task_struct(tsk)	free_pages((unsigned long) (tsk), KERNEL_STACK_SIZE_ORDER)
> +#define alloc_task_struct()	((struct task_struct *)__alloc_vcompound( \
> +			GFP_KERNEL, KERNEL_STACK_SIZE_ORDER))

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/