Re: [PATCH 2/6] compcache: block device - internal defs

[Nitin Gupta]

On Mon, Mar 24, 2008 at 9:55 PM, Mariusz Kozlowski
<m.kozlowski@xxxxxxxxxx> wrote:
> Hi Nitin,
>
>
>  >  +#define K(x)   ((x) >> 10)
>  >  +#define KB(x)  ((x) << 10)
>
>  Hm. These look cryptic unless you remember what they do.
>  Could have better names?

I'll give them better names/add comments.

>
>
>  > +#define CC_DEBUG2((fmt,arg...) \
>  > +       printk(KERN_DEBUG C fmt,##arg)
>
>  Unbalanced parenthesis.
>

Corrected. Thanks.

- Nitin

>  Just my 0.05zl.
>
>         Mariusz
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/