Re: [PATCH] CPA: Add statistics about state of direct mapping v3

[Thomas Gleixner]

On Tue, 25 Mar 2008, Andi Kleen wrote:

> On Tue, Mar 25, 2008 at 04:40:43PM +0100, Thomas Gleixner wrote:
> > On Sat, 22 Mar 2008, Andi Kleen wrote:
> > 
> > > [I didn't switch to debugfs because I strongly disagreed with that
> > > suggestion. But all the other points you made are addressed.]
> > 
> > Halfways :)
> 
> Ok.
> 
> > > +	update_page_count(PG_LEVEL_1G, pages);
> > > +
> > 
> >   update via function call with pages = 0 ?
> 
> Didn't get that one. Can you clarify?

You have the direct increment and the function call in
phys_pud_init. The function is always called with pages=0 because
nothing ever increments pages.

Thanks,
	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/