ohci : strange looking use of round_jiffies_relative. possible bug?
From: Richard Kennedy
Date: Wed Mar 26 2008 - 10:48:23 EST
I was looking at the uses of round_jiffies and noticed that the ohci
unlink_watchdog_func() calls
mod_timer(&ohci->unlink_watchdog, round_jiffies_relative(HZ));
Which looks a bit strange as it will set the timer to 0 <= t < HZ.
Reading the comments I think that is really is expecting to setup timer
to (now + 1s)
mod_timer(&ohci->unlink_watchdog, round_jiffies(jiffies + HZ));
If this is not true then perhaps it needs a comment to explain what it
_is_ trying to do, because it's got me baffled ;)
Cheers
Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/