Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend andhibernation callbacks (rev. 4)

From: Benjamin Herrenschmidt
Date: Wed Mar 26 2008 - 22:54:23 EST



On Thu, 2008-03-27 at 02:23 +0100, Rafael J. Wysocki wrote:
> On Thursday, 27 of March 2008, Benjamin Herrenschmidt wrote:
> >
> > > > There is absolutely no point getting a second struct anymore.
> > >
> > > I obviously disagree with that opinion, so please elaborate.
> >
> > Well, what does it bring you ? Why can't it be one struct ? To save
> > space in the data area ?
>
> Mostly, but not only that.
>
> There are users of 'struct pm_ops' that aren't even supposed to define the
> _noirq callbacks (device types and device classes), so I thought it would be
> better to introduce a separate _noirq struct after all.

Make sense... USB has no use of noirq for example.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/