Re: [PATCH -mm 1/4] x86_64 boot: Add free_early to early reservation machanism

From: Andi Kleen
Date: Thu Mar 27 2008 - 08:09:11 EST


On Thu, Mar 27, 2008 at 12:58:51PM +0100, Ingo Molnar wrote:
>
> * Paul Jackson <pj@xxxxxxx> wrote:
>
> > Huang wrote:
> > > + panic("free_early on not reserved area: %lx-%lx!", start, end);
> >
> > Should that be 'early_panic', not 'panic' ?
> >
> > (I see a couple more panics in that file, which I wonder
> > if should be early_panic as well ?)
>
> this should be fixed properly btw: panic() should self-select whether it
> does an early_panic() or a real panic().

There's also need of a EARLY_BUG, but self selection would be a little
tricky here.

I still have an old patch for this, but I haven't gotten around to submit it
because it turned out the first user of it wasn't a good idea.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/