Re: [PATCH 1/3] Clocklib: add generic framework for managing clocks.

From: Dmitry
Date: Thu Mar 27 2008 - 09:34:13 EST


Hi,

2008/3/27, Haavard Skinnemoen <haavard.skinnemoen@xxxxxxxxx>:
> On Thu, 27 Mar 2008 13:08:37 +0300
>
> Dmitry <dbaryshkov@xxxxxxxxx> wrote:
>
>
> > I like this idea! This would also allow to cleanup the references code, etc.
>
>
> Great!
>
>
> > Also after I saw such refactored struct clk, I thought that it looks
> > nearly like kobject. Maybe we should switch to the kobject-based
> > structs? What do you think?
>
>
> I think that would be overkill. We should try to keep this stuff as
> lightweight as possible, and I'm not sure if we can give the kobject
> "parent" field the meaning we want it to have...or use the kref thing
> to do something unrelated to object lifecycle management (i.e. we don't
> want to destroy the object when the refcount goes to zero, we just want
> to stop the clock.)

ACK. Then I'll repost the updated patchset later.

--
With best wishes
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/