Re: [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot

From: David Miller
Date: Thu Mar 27 2008 - 20:05:13 EST


From: Joe Perches <joe@xxxxxxxxxxx>
Date: Thu, 27 Mar 2008 17:02:37 -0700

> I think this is the sort of change you might have argued
> against accepting without performance testing not long ago.

Look at how complicated the assembler of this function
is. Any inlining performance gains will be trumped by
the instruction cache usage bloat.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/