Re: agpgart: when telling user you'll corrupt his data, at least do it at KERN_CRIT

[Andi Kleen]

On Fri, Mar 28, 2008 at 12:25:07PM +0100, Pavel Machek wrote:
> 
> IOMMU off means very bad stuff may happen, like data corruption on

Actually swiotlb takes over then in this case. The printk really
predates the introduction of swiotlb and could be actually removed.
That is why swiotlb is always SELECTed for gart too.

> your hard drives. At least tells users this is serious...

No there shouldn't be any data corruption with the default options.

Also especially hard disk drivers are expected (and generally do)
check the dma_map_sg() etc. return values and bail out if the IOMMU
fails e.g. due to overflow.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/