Re: Kconfig RTC selection (was: 2.6.25-rc7: Ugh.)

From: David Brownell
Date: Fri Mar 28 2008 - 17:24:27 EST


On Friday 28 March 2008, Adrian Bunk wrote:
> >   "JS_RTC" ... a SPARC32 thing
> >       --> bug?? no "js-rtc.c" in the tree!  patch sent
>
> Where's the bug?
> js-rtc is built from rtc.c

In which case, just enable rtc.c ... a "egrep -r 'JS_RTC|js-rtc'"
shows that it looks pretty pointless.


> >...
> >   "DS1302" ... M32R-specific, "rtc-ds1302" should replace it
> >       --> ready to deprecate now?
> >...
>
> Kconfig currently offers rtc-ds1302 only for an sh platform...

Right, I looked at that a bit more. The rtc-ds1302 code was
not written portably. If it were updated to get addresses
from platform resources -- like *normal* platform drivers do,
since the addresses are platform specific -- and if those two
M32R platforms got updated ... *then* this could be deprecated.

- Dave



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/