Re: Comma at end of enum lists

[H. Peter Anvin]

Al Viro wrote:
> On Sat, Mar 29, 2008 at 10:20:38AM -0700, H. Peter Anvin wrote:
> > Jacek Luczak wrote:
> > > Hi All,
> > >
> > > I've found that in many enum lists, there's a comma at the end, e.g. 
> > > (arch/x86/kernel/early_printk.c):
> > >
> > > enum {
> > >        MAGIC1 = 0xBACCD00A,
> > >        MAGIC2 = 0xCA110000,
> > >        XOPEN = 5,
> > >        XWRITE = 4,
> > > };
> > >
> > > Just out of curiosity, is there any particular reason here (no word in 
> > > CodingStyle about that).
> > Yes, it's so you can add a line without affecting the line before it, 
> > making a one-line patch into a two-line patch that's more likely to 
> > conflict.
>
> Note that doing that makes sense only when you can expect additions to
> the end and even then it's a matter of taste.

Yes, it is.

I personally prefer it this way (strongly) for exactly the same reason C 
requires a semicolon at the end of each statement, as opposed to Pascal 
which doesn't require a semicolon immediately before an "end".

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/