Re: [PATCH 8/35] W1: feature, w1_therm.c use strong pullup

From: Evgeniy Polyakov
Date: Sun Mar 30 2008 - 07:30:42 EST


On Fri, Mar 28, 2008 at 07:25:10AM -0500, David Fries (david@xxxxxxxxx) wrote:
> w1_therm.c 1.3 1.4 1.10
> Use the strong pullup not the sleep. Note that the pullup goes before
> W1_CONVERT_TEMP not after.
> +w1_next_pullup(dev, tm);
> w1_write_8(dev, W1_CONVERT_TEMP);
> -msleep(tm);

I'm ok with it, but believe it has to be turned off by default and be
able to be turned on by parameter.

Did you test it with multiple devices on the same bus?

--
Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/