Re: [PATCH 8/8] x86_64: Support for new UV apic

[Yinghai Lu]

On Sun, Mar 30, 2008 at 7:06 PM, Jack Steiner <steiner@xxxxxxx> wrote:
> > so this is "the new one of Friday"?
>
>  Yes, and it has the same bug although it is located
>  in a slightly different place.
>
>  A few minutes ago, I posted a patch to delete the extra lines.
>
>
>
>  > Did you test it on non UV_X2APIC box?
>
>  The code is clearly wrong.  I booted on an 8p AMD box and
>  had no problems. Apparently the kernel (at least basic booting) is
>  not too sensitive to incorrect apicids being returned. Most
>  critical-to-boot code must use apicids from the ACPI tables.
>  However, the bug does affect numa node assignment. And probably
>  other places, too.

please consider one global get_apic_id() and bad_apicid to replace
GET_APIC_ID and BAD_APICID at this point.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/