Re: [PATCH 4 of 6] hotplug-memory: use common online_page

From: Dave Hansen
Date: Thu Apr 03 2008 - 21:22:52 EST



On Thu, 2008-04-03 at 18:11 -0700, Jeremy Fitzhardinge wrote:
> Dave Hansen wrote:
> > I guess we could just make the copies conditional on CONFIG_HIGHMEM and
> > define them both next to each other. It's really a highmem thing more
> > than a per-arch thing.
>
> Sounds good to me. On that subject, how different are the various
> arch_add_memory() functions really? There seems to be a lot of common
> stuff in there.

Not to different last I looked. But, they're small enough (like
online_page()) that we didn't really care. We waited for someone like
you to come along and care enough to fix it up. :)

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/