Re: [PATCH 1/3] hugetlbfs: architecture header cleanup
From: Andrew Morton
Date: Tue Apr 08 2008 - 00:00:20 EST
On Fri, 04 Apr 2008 18:49:50 +0200 Gerald Schaefer <gerald.schaefer@xxxxxxxxxx> wrote:
> Subject: [PATCH 1/3] hugetlbfs: architecture header cleanup
>
> From: Gerald Schaefer <gerald.schaefer@xxxxxxxxxx>
>
> This patch moves all architecture functions for hugetlb to architecture
> header files (include/asm-foo/hugetlb.h) and converts all macros to inline
> functions. It also removes (!) ARCH_HAS_HUGEPAGE_ONLY_RANGE,
> ARCH_HAS_HUGETLB_FREE_PGD_RANGE, ARCH_HAS_PREPARE_HUGEPAGE_RANGE,
> ARCH_HAS_SETCLEAR_HUGE_PTE and ARCH_HAS_HUGETLB_PREFAULT_HOOK.
>
> Getting rid of the ARCH_HAS_xxx #ifdef and macro fugliness should increase
> readability and maintainability, at the price of some code duplication.
> An asm-generic common part would have reduced the loc, but we would end up
> with new ARCH_HAS_xxx defines eventually.
>
> Acked-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> Signed-off-by: Gerald Schaefer <gerald.schaefer@xxxxxxxxxx>
> ---
>
> include/asm-ia64/hugetlb.h | 37 +++++++++++++++++++++++++++++++
> include/asm-ia64/page.h | 6 -----
> include/asm-powerpc/hugetlb.h | 37 +++++++++++++++++++++++++++++++
> include/asm-powerpc/page_64.h | 7 ------
> include/asm-sh/hugetlb.h | 49 ++++++++++++++++++++++++++++++++++++++++++
> include/asm-sparc64/hugetlb.h | 42 ++++++++++++++++++++++++++++++++++++
> include/asm-sparc64/page.h | 2 -
> include/asm-x86/hugetlb.h | 49 ++++++++++++++++++++++++++++++++++++++++++
> include/linux/hugetlb.h | 46 ---------------------------------------
Seem that git-s390 is currently carrying the old versions of these patches.
I'll drop git-s390. Which will presumably kick off a cascade of droppages
due to git-s390 versus git-kvm damage control. All of which will need to
be undropped in some fashion when those trees come to their senses. Ho
hum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/