Re: [PATCH 6/6] Clocklib: use correct name for 3,6MHz clock

[Russell King]

On Tue, Apr 08, 2008 at 01:52:41PM +0400, Dmitry wrote:
> 2008/4/8, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>:
> > On Thu, 3 Apr 2008 17:24:11 +0400
> >  Dmitry Baryshkov <dbaryshkov@xxxxxxxxx> wrote:
> >
> >  > Signed-off-by: Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>
> >  > ---
> >  >  arch/arm/common/sa1111.c |    2 +-
> >  >  1 files changed, 1 insertions(+), 1 deletions(-)
> >  >
> >  > diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c
> >  > index eb06d0b..282a4d9 100644
> >  > --- a/arch/arm/common/sa1111.c
> >  > +++ b/arch/arm/common/sa1111.c
> >  > @@ -627,7 +627,7 @@ __sa1111_probe(struct device *me, struct resource *mem, int irq)
> >  >       if (!sachip)
> >  >               return -ENOMEM;
> >  >
> >  > -     sachip->clk = clk_get(me, "GPIO27_CLK");
> >  > +     sachip->clk = clk_get(me, "3_6MHz_CLK");
> >  >       if (!sachip->clk) {
> >  >               ret = PTR_ERR(sachip->clk);
> >  >               goto err_free;
> >
> >
> > Again, there's just not enough information for us (well: me) to be able to
> >  evaluate this patch.
> >
> >  For example, if the current name is "incorrect" then why shouldn't we fix
> >  it in 2.6.25?  2.6.24?  etc.
> >
> >
> 
> The name GPIO27_CLK came from sa1100 arm sub-arch. There the 3.6 MHz
> clock was provided via GPIO 27. The PXA clocks code have copied the
> name for the clock (as it's used by sa1111 companion chip that can be
> used with both sa1100 and pxa). However on pxa the 3.6MHz clock is
> provided by different PIN. So the name GPIO27_CLK is misleading and
> incorrect for PXA.

So... what is the correct name.  Bear in mind what I said in the previous
reply this evening - which says that it should be the name used by the
SA1111.  Look in the data sheet - the pin itself to which the 3.6MHz
clock is supplised will have a name.  That's the name which should be
used.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/