Re: [PATCH] usb: add sysfs configuration interface for CP2101

[Andy Whitcroft]

On Fri, Feb 29, 2008 at 12:35:12PM -0800, Andrew Morton wrote:

> > +static int enable_config = false;
> 
> Should be either
> 
> static int enable_config;
> 
> or, if you're being very formal,
> 
> static bool enable_config = false;
> 
> or, if you're being less formal and want to avoid bloating the kernel image,
> 
> static bool enable_config;

I've added detection of false as a 0 value in external and static
contexts; this should be reported in the 0.18:

ERROR: do not initialise statics to 0 or NULL
#1: FILE: Z118.c:1:
+static bool enable_config = false;

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/