Re: [PATCH] [12/18] Add support to allocate hugetlb pages that are larger than MAX_ORDER

From: Andi Kleen
Date: Wed Apr 09 2008 - 13:52:16 EST


> This looks like an off-by-one error here and in the code below -- it
> should be ">= MAX_ORDER" not "> MAX_ORDER". Cf alloc_pages() in gfp.h:
>
> if (unlikely(order >= MAX_ORDER))
> return NULL;

True good point. Although it will only matter if some architecture
has MAX_ORDER sized huge pages :) x86-64 definitely hasn't.

I passed this code over to Nick so he'll hopefully incorporate the fix.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/