Re: local_softirq_pending()

[Heiko Carstens]

On Wed, Apr 09, 2008 at 07:27:08PM -0700, Andrew Morton wrote:
> kernel/time/tick-sched.c: In function 'tick_nohz_stop_sched_tick':
> kernel/time/tick-sched.c:229: warning: format '%02x' expects type 'unsigned int', but argument 2 has type '__u64'
> 
> I don't think the architecture's local_softirq_pending() should return u64.
> This is the sort of thing which should be consistent across architectures.
> 
> Problem is, we've made such a complete mess of everything that this is a
> bitch to fix.
> 
> The obvious and moderately clean fix is:

I think I will just change the type of softirq_pending in s390's struct lowcore
from __u64 to __u32. That should be the least intrusive "fix" for this problem.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/