Re: [patch 4/15] fs/logfs/compr.c

From: Arnd Bergmann
Date: Thu Apr 10 2008 - 10:14:19 EST


On Tuesday 01 April 2008, joern@xxxxxxxxx wrote:
> +
> +static DEFINE_MUTEX(compr_mutex);
> +static struct z_stream_s stream;
> +

How much time is spent in the compression code? Would it be helpful
to have a percpu stream and do preempt_disable around it instead
of the mutex?

That would improve parallelism and cache-locality of the compression,
at the cost of adding a source of latency to preemptible kernels.

Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/