Re: [PATCH 5/7] PPS: serial clients support.

From: Rodolfo Giometti
Date: Thu Apr 10 2008 - 11:37:44 EST


On Thu, Apr 10, 2008 at 04:28:12PM +0100, Alan Cox wrote:
> On Thu, 10 Apr 2008 17:15:58 +0200
> Rodolfo Giometti <giometti@xxxxxxxx> wrote:
>
> > Adds support for the PPS sources connected with the CD (Carrier
> > Detect) pin of a serial port.
>
> Ok why does this need to hack the driver layer ?
>
> > -static void uart_change_speed(struct uart_state *state,
> > - struct ktermios *old_termios);
> > +static void uart_change_speed(struct uart_state *state, struct ktermios *old_termios);
>
> NAK. Please remove random formatting changes

Sorry, this patch is wrong! I'll re-submit the right code. '-_-

Thanks,

Rodolfo

--

GNU/Linux Solutions e-mail: giometti@xxxxxxxxxxxx
Linux Device Driver giometti@xxxxxxxx
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/