Re: [patch 10/17] mm: fix bootmem alignment

From: Yinghai Lu
Date: Thu Apr 10 2008 - 13:34:01 EST


On Thu, Apr 10, 2008 at 10:02 AM, <npiggin@xxxxxxx> wrote:
> Without this fix bootmem can return unaligned addresses when the start of a
> node is not aligned to the align value. Needed for reliably allocating
> gigabyte pages.
>
> I removed the offset variable because all tests should align themself correctly
> now. Slight drawback might be that the bootmem allocator will spend
> some more time skipping bits in the bitmap initially, but that shouldn't
> be a big issue.
>


this patch from Andi was obsoleted by the one in -mm


The patch titled
mm: offset align in alloc_bootmem
has been added to the -mm tree. Its filename is
mm-offset-align-in-alloc_bootmem.patch

------------------------------------------------------
Subject: mm: offset align in alloc_bootmem
From: Yinghai Lu <yhlu.kernel.send@xxxxxxxxx>

Need offset alignment when node_boot_start's alignment is less than align
required

Use local node_boot_start to match align. so don't add extra opteration in
search loop.

Signed-off-by: Yinghai Lu <yhlu.kernel@xxxxxxxxx>
Cc: Andi Kleen <ak@xxxxxxx>
Cc: Yasunori Goto <y-goto@xxxxxxxxxxxxxx>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxx>
Cc: Christoph Lameter <clameter@xxxxxxx>
Cc: Mel Gorman <mel@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/