Re: [PATCH] lzo: fix possible typo in decompresor

[Harvey Harrison]

On Thu, 2008-04-10 at 13:49 -0700, Linus Torvalds wrote:
> 
> On Thu, 10 Apr 2008, Harvey Harrison wrote:
> >
> > Shift of a le value seems strange, probably meant to shift the cpu-order
> > variable as in the prvious section of the switch statement.
> 
> Hmm. This patch looks ObviouslyCorrect(tm), but it worries me that 
> apparently the old broken code has been around since last July, and afaik 
> it can never have worked on big-endian machines.
> 
> So did nobody ever use it, or why hasn't this ever triggered? How did you 
> find this? A sparse warning?
> 
> 		Linus

When converting in tree users to my proposed unaligned byteswapping api.
See the 8 patch series posted today to linux-arch.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/