[PATCH 1/2] firewire: fw-ohci: fix debug logging of phy packets

From: Stefan Richter
Date: Thu Apr 10 2008 - 18:49:58 EST


Fix harmless but irritating off-by-one bug in patch "firewire: debug
interrupt events". Should be folded into that one.

See OHCI 1.1 clause 8.7.1.4.

Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>
---
drivers/firewire/fw-ohci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Index: linux/drivers/firewire/fw-ohci.c
===================================================================
--- linux.orig/drivers/firewire/fw-ohci.c
+++ linux/drivers/firewire/fw-ohci.c
@@ -371,10 +371,10 @@ static void log_ar_at_event(char dir, in
if (unlikely(evt >= ARRAY_SIZE(evts)))
evt = 0x1f;

- if (header[0] == ~header[1]) {
+ if (header[1] == ~header[2]) {
printk(KERN_DEBUG "A%c %s, %s, %08x\n",
- dir, evts[evt], phys[header[0] >> 30 & 0x3],
- header[0]);
+ dir, evts[evt], phys[header[1] >> 30 & 0x3],
+ header[1]);
return;
}


--
Stefan Richter
-=====-==--- -=-- -=-==
http://arcgraph.de/sr/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/