Re: [regression] e1000e broke e1000

From: Ingo Molnar
Date: Fri Apr 11 2008 - 07:31:12 EST



* Jeff Garzik <jeff@xxxxxxxxxx> wrote:

>> So i'm not sure why you are arguing about all this. Please just fix
>> this bug, simple as that.
>
> I haven't said NAK, but I think the suggested fix is a waste of time
> because
>
> 1) it breaks (by disallowing) a valid setup based on one report
>
> 2) it only happens to experienced kernel hackers with weird configs
>
> 3) the suggested fix binds together more tightly two drivers we are
> trying to keep separate
>
> 4) it is a temporary situation that will go away in 2.6.26 anyway

well, your 2.6.26 plans, if i understand them correctly, is to move
currently working PCI IDs from e1000 to e1000e, like you attempted to d
it in v2.6.24, which Linus reverted - correct? I.e. e1000 simply wont
support eth0 on my T60 from 2.6.26 on? That is still an incredibly
stupid plan, and no amount of announcement on lkml will make it any less
stupid.

... which pretty much pulls the rug from under your argument, no?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/