Re: [PATCH] sb1000.c: stop inlining largish static functions

[Jeff Garzik]

Denys Vlasenko wrote:
> Hi Jeff,
>
> Can you take this patch into your net driver fixes tree?
>
> drivers/net/sb1000.c has lots of inlined static functions.
>
> Mst of them are used at initialization, wait for some
> hardware register to change (wait using yield, sleep etc),
> or do slow port-based I/O. Inlining thse "for speed" makes no sense.
>
> This patch removes "inline" from biggest static function
> (regardless of number of callsites - gcc nowadays auto-inlines
> statics with one callsite).
>
> Size difference for 32bit x86:
>
>    text    data     bss     dec     hex filename
>    6299     129       0    6428    191c linux-2.6-ALLYES/drivers/net/sb1000.o
>    5418     129       0    5547    15ab linux-2.6.inline-ALLYES/drivers/net/sb1000.o
>
> (I also see some other optimization opportunities,
> will test and send a patch separately).
>
> Signed-off-by: Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>

applied both patches


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/