Re: [PATCH] x86: setup_trampoline() - fix section mismatch warning

[Jacek Luczak]

Hi Sam,

Sam Ravnborg pisze:
[!snip]
>> diff --git a/arch/x86/kernel/trampoline_64.S b/arch/x86/kernel/trampoline_64.S
>> index 4aedd0b..2a07e67 100644
>> --- a/arch/x86/kernel/trampoline_64.S
>> +++ b/arch/x86/kernel/trampoline_64.S
>> @@ -32,7 +32,7 @@
>>  
>>  /* We can free up trampoline after bootup if cpu hotplug is not supported. */
>>  #ifndef CONFIG_HOTPLUG_CPU
>> -.section .init.data, "aw", @progbits
>> +.section .cpuinit.data, "aw", @progbits
>>  #else
>>  .section .rodata, "a", @progbits
>>  #endif
> 
> The correct fix would be to drop the
> preprocessor directves and use __CPUINITDATA

Hmm...IMO this should stay in that form at least now.
I will make some tests with __CPUINITDATA (look into objects, etc.) and later on we can
switch. Is it OK for you?

> 
> Like this: (hand edited):
> 
>> diff --git a/arch/x86/kernel/trampoline_64.S b/arch/x86/kernel/trampoline_64.S
>> index 4aedd0b..2a07e67 100644
>> --- a/arch/x86/kernel/trampoline_64.S
>> +++ b/arch/x86/kernel/trampoline_64.S
>> @@ -32,7 +32,7 @@
>>  
>>  /* We can free up trampoline after bootup if cpu hotplug is not supported. */
>>  #ifndef CONFIG_HOTPLUG_CPU
>> -.section .init.data, "aw", @progbits
>> -#else
>> -.section .rodata, "a", @progbits
>> -#endif
>> +__CPUINITDATA
> 
> If your testing confirms this then please apply similar fix to the _32.S
> version of the file too.

Yep, I'm now working on 32bit stuff.

-Jacek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/