Re: [PATCH 1/2] firewire: fw-ohci: fix debug logging of phy packets

[Stefan Richter]

I wrote:
> --- linux.orig/drivers/firewire/fw-ohci.c
> +++ linux/drivers/firewire/fw-ohci.c
> @@ -371,10 +371,10 @@ static void log_ar_at_event(char dir, in
>  	if (unlikely(evt >= ARRAY_SIZE(evts)))
>  			evt = 0x1f;
>  
> -	if (header[0] == ~header[1]) {
> +	if (header[1] == ~header[2]) {
>  		printk(KERN_DEBUG "A%c %s, %s, %08x\n",
> -		       dir, evts[evt], phys[header[0] >> 30 & 0x3],
> -		       header[0]);
> +		       dir, evts[evt], phys[header[1] >> 30 & 0x3],
> +		       header[1]);

This patch is bogus.  The indices were right.
-- 
Stefan Richter
-=====-==--- -=-- -==--
http://arcgraph.de/sr/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/