Re: [PATCH 2/3] x86: Implement prctl PR_GET_TSC and PR_SET_TSC

[H. Peter Anvin]

Arjan van de Ven wrote:
> Hi,
>
> why did you make this a configuration option? In general it's not
> a good idea to make userspace visible ABI's (PR_* clearly is one of these)
> a CONFIG option unless there's some HUGE space saving going on.
> I don't see that here....
>
> So can you explain your rationale for making this a config option?

I also saw no mention about performance impact, which need to be 
considered whenever *anything* is proposed to be inserted into a hot 
path.  It may be (heck, *should be*) that the performance impact isn't 
measurable, but that needs to be positively established.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/