Re: [PATCH 6/8] rfkill: add the WWAN radio type

[Inaky Perez-Gonzalez]

On Saturday 12 April 2008, Henrique de Moraes Holschuh wrote:
> On Sat, 12 Apr 2008, Ivo van Doorn wrote:
> > On Friday 11 April 2008, Henrique de Moraes Holschuh wrote:
> > > Unfortunately, instead of adding a generic Wireless WAN type, a technology-
> > > specific type (WiMAX) was added.  That's useless for other WWAN devices,
> > > such as EDGE, UMTS, X-RTT and other such radios.
> > 
> > Then perhaps we should replace WiMAX with the WWAN type?
> 
> And have KEY_WIMAX interact with WWAN, or rename KEY_WIMAX to KEY_WWAN as
> well?
> 
> I do think it should be OK to do both renames, since it is very unlikely
> that a device would have keys for WIMAX and WWAN at the same type.  We
> don't even have to rename KEY_WIMAX, we can have KEY_WWAN and KEY_WIMAX map
> both to the same keycode.
> 
> Inaky?

I disagree

Most rfkill hw keys are attached to the device. So I can plug wifi, wimax,
3G, UWB and BT dongles (or cards) into a system and they each provide a HW
switch (or should provide).

If each overrides another one, we have a problem.

Is it that unlikely that a device will have 3G and WiMAX support? Not 
really. My laptop might have WWAN built in and then when I travel to some
place where I need WiMAX, I plug a WiMAX USB dongle. Problem. This is just
an example that can be extended to any wireless technology combination.

My point is we should keep it kind of separated, where the guy requesting
the rfkill stuff says "I need a keycode to generate when my hw switch is
operated". And for the rfkill layer to just care about associating that
keycode to that card.

I guess before I didn't have it as clear as I do now, but I am just seeing
more and more that each radio has its own kill switch and then the system
might have a generic one (for example fn+F5 on thinkpads) for killing all
of them at the same time.



-- 
Inaky
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/