Re: [PATCH] printk: Remember the message level for multi-lineoutput

[Ingo Molnar]

* Nick Andrew <nick@xxxxxxxxxxxxxxx> wrote:

> Modify vprintk() to remember the message loglevel each time it is 
> specified and use it for subsequent lines of output which do not 
> specify one, within the same call to printk.
> 
> Restructure the logic so the processing of the leading 3 characters of 
> each input line is in one place, regardless whether printk_time is 
> enabled.

hm, i'm not sure about the change itself (printks are often random, so 
the output to the console would depend on printk ordering), but the 
combined effect seems to be a nice cleanup that reduces the linecount:

>  1 files changed, 27 insertions(+), 34 deletions(-)

so how about splitting it into two, first the code restructuring then a 
small add-on that does your feature? Does this make sense to you? This 
way, even if the feature ends up not being applied, we'll have your nice 
cleanup :-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/