Re: [PATCH 3/7] omfs: add directory routines

From: Alan Cox
Date: Sun Apr 13 2008 - 05:16:20 EST



> +static int omfs_readdir(struct file *filp, void *dirent, filldir_t filldir)
> +{
> + struct inode *dir = filp->f_dentry->d_inode;
> + struct buffer_head *bh = NULL;

> + if (filp->f_pos >> 32)
> + goto success;

f_pos may be 32bit in which case >> 32 does not have defined behaviour in
C.


Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/