Re: [patch 2/2] bootmem: Node-setup agnostic free_bootmem()

[Johannes Weiner]

Hi,

"Yinghai Lu" <yhlu.kernel@xxxxxxxxx> writes:

> On Sat, Apr 12, 2008 at 3:33 PM, Johannes Weiner <hannes@xxxxxxxxxxxx> wrote:
>> Make free_bootmem() look up the node holding the specified address
>>  range which lets it work transparently on single-node and multi-node
>>  configurations.
>>
>>  Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxxx>
>>  CC: Yinghai Lu <yhlu.kernel@xxxxxxxxx>
>>  CC: Andi Kleen <ak@xxxxxxx>
>>  CC: Yasunori Goto <y-goto@xxxxxxxxxxxxxx>
>>  CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
>>  CC: Ingo Molnar <mingo@xxxxxxx>
>>  CC: Christoph Lameter <clameter@xxxxxxx>
>>  CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>>  ---
>>
>>  Patch tested on x86_32 uma.
>>
>>  Index: linux-2.6/mm/bootmem.c
>>  ===================================================================
>>  --- linux-2.6.orig/mm/bootmem.c
>>  +++ linux-2.6/mm/bootmem.c
>>  @@ -421,7 +421,15 @@ int __init reserve_bootmem(unsigned long
>>
>>   void __init free_bootmem(unsigned long addr, unsigned long size)
>>   {
>>  -       free_bootmem_core(NODE_DATA(0)->bdata, addr, size);
>>  +       bootmem_data_t *bdata;
>>  +
>>  +       list_for_each_entry (bdata, &bdata_list, list) {
>>  +               if (addr < bdata->node_boot_start)
>>  +                       continue;
>
> could have chance that bootmem with reserved_early that is crossing
> the nodes.

Upstream reserve_bootmem_core() would BUG() on a caller trying to cross
nodes, so I don't see where this chance could come from.

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/