Re: [rfc] hw resource debugging checks (was: Re: x86 git treebroken (bisected))

From: Arjan van de Ven
Date: Sun Apr 13 2008 - 11:53:33 EST


On Sun, 13 Apr 2008 09:58:45 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

>
> * Rafael J. Wysocki <rjw@xxxxxxx> wrote:
>
> > > > btw., Xorg works fine here on a comparable AMD system - but i
> > > > use a rather new distro (Fedora 8) which has Xorg 7.2.
> > >
> > > My system is an OpenSUSE 10.3 and it has Xorg 7.2 as well.
> > >
> > > I think the problem is somehow related to the Radeon.
> >
> > The bisection turned up commit
> > ea1441bdf53692c3dc1fd2658addcf1205629661 "x86: use bus conf in NB
> > conf fun1 to get bus range on, on 64-bit" as the one causing
> > problems.
>
> thanks Rafael for bisecting this!
>
> This was a rather nasty problem - and i'm wondering what else we
> could do to harden our hw resource management code. I'm wondering, is
> there any particular reason why clearly broken resource setup is not
> detected somewhere, automatically, and WARN_ON()-ed about?

that would be very welcome, esp if kerneloops.org can pick them up.

One thing we also need to do as Linux is get more conservative;
(this isn't per se about this specific thing)

With MCFG for example we learned over time "if it smells funny don't use it".
That concept should be carried much further imo; for example on K8 you
can compare the acpi table to the chipset for numa support, and if they don't match,
we SHOULD ignore both entirely.
The same is true all over; Linux tends to behave as "oh but we think we can make it work anyway",
in general imo that's a mistake in the long term, at least for default configs. Because there
will be cases where that will break, be it special bioses or next gens of chipsets.


--
If you want to reach me at my work email, use arjan@xxxxxxxxxxxxxxx
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/