Re: [PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 8)

[Rafael J. Wysocki]

On Monday, 14 of April 2008, Benjamin Herrenschmidt wrote:
> 
> > Please have a look at this thread:
> > http://lkml.org/lkml/2008/3/21/322
> > (in short, the reporter sees APM suspend breakage under stress, occuring
> > because APM uses our suspending of devices without the freezer).
> 
> Note that the above seems to lack any useful information (as usual) such
> as what block driver is involved etc...
> 
> We fixed IDE to be robust vs. pending IOs a while ago. It's possible
> that libata isn't as solid yet, I don't know.
> 
> This needs to be done regardless of feezer vs. not freezer. There are
> thins in the kernel that can trigger BIOs at any time pretty much
> regardless of user space being frozen or not, again, it's a case of
> sticking our head in the sand and hoping the freezer hides all our
> design bugs.

Now, you are talking about a completely different thing I agree with.

I gave this example just to show that some drivers break without the freezer
if suspend is carried out under stress, nothing else.

My point is (and has always been) that we can't just drop the freezer right now
without causing functional regressions to appear, at least for some users.

If there had not been _any_ other way to do things, we could do that, but IMO
there is a way (that I described in the previous message).

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/