Re: [patch] F_GETPATH for linux

[Davide Libenzi]

On Mon, 14 Apr 2008, Arnd Bergmann wrote:

> On Monday 14 April 2008, Davide Libenzi wrote:
> > I was working on some bsd/linux compatibility code, and I noticed that we 
> > do not have F_GETPATH. I know we can readlink /proc/PID/fd/FD (that is 
> > what I'm doing now, under #ifdef), but I gave a patch a shot anyway.
> > Here it is, building but untested ...
>  
> I reviewed the code path for compat_sys_fcntl{,64} for this patch, looks
> good in that respect.
> 
> > +error:
> > +	free_page((unsigned long) buf);
> > +	return size;
> > +}
> > +EXPORT_SYMBOL(fcntl_getpath);
> > +
> 
> Procfs cannot be a module, and there are no other users of this function,
> so why do you export it?

Springtime export fever? :)
I dropped the export. I'll repost as soon as I've five minutes to reboot 
my box (to test the thing a little).



- Davide


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/