Re: 2.6.25-rc9 -- INFO: possible circular locking dependencydetected

[Ingo Molnar]

* Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote:

> On Mon, Apr 14, 2008 at 08:54:05AM +0200, Peter Zijlstra wrote:
> > Fun,
> > 
> > I will need to sort out this code before I can say anything about that,
> > perhaps Gautham and or Rafael have ideas before I can come up with
> > something.. ?
> 
> Why not simply removing the get/put_online_cpus() pair in 
> sched_getaffinity? It's superfluous since we have already a 
> read_lock/read_unlock pair there which does disable/enable cpu hotplug 
> anyway.

we dont want to insert such silent "preempt off == hotplug disable" 
assumptions - which assumption breaks when the tasklist_lock becomes 
preemptible (such as in -rt).

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/