Re: Pageflags: Standardize comment inclusion in asm-offsets.h andfix MIPS

[Andrew Morton]

On Mon, 14 Apr 2008 11:43:08 -0700 (PDT)
Christoph Lameter <clameter@xxxxxxx> wrote:

> Add the ability to pass comments into asm-offsets.h by generating asm
> output like
> 
> -># comment line
> 
> Mips needs this feature to preserve the comments that are in asm-mips/asm-offsets.h
> right now.
> 
> Then remove the special handling for mips from Kbuild and convert mips to use
> the new string to include the comments.

OK, let's try that.  Ralf, could you please review it?


afaict this change is not dependent upon the other page-flags changes and
can and should be merged ahead of the page-flags patches to preserve mips
bisectability, yes?

Mips and sparc64 are hopefully now mended.  powerpc allmodconfig is still
unwell:

  CC      arch/powerpc/kernel/asm-offsets.s
In file included from include/linux/gfp.h:4,
                 from include/linux/slab.h:14,
                 from include/linux/percpu.h:5,
                 from include/asm/time.h:18,
                 from include/asm/cputime.h:26,
                 from include/linux/sched.h:67,
                 from arch/powerpc/kernel/asm-offsets.c:17:
include/linux/mmzone.h:830:2: error: #error Allocator MAX_ORDER exceeds SECTION_SIZE

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/